Skip to content

Encode URIs during server rendering of <a href>/<form action> to avoi… - #10769

Merged
ryanflorence merged 7 commits into
devfrom
brophdawg11/encode-server-HTML-paths
Aug 11, 2023
Merged

Encode URIs during server rendering of <a href>/<form action> to avoi…#10769
ryanflorence merged 7 commits into
devfrom
brophdawg11/encode-server-HTML-paths

Conversation

@brophdawg11

@brophdawg11 brophdawg11 commented Aug 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-bot Bot commented Aug 8, 2023 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f135058

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brophdawg11
brophdawg11 commented Aug 9, 2023
View reviewed changes
Comment thread packages/react-router-dom/index.tsx Outdated
brophdawg11
brophdawg11 commented Aug 10, 2023
View reviewed changes
Comment thread packages/react-router-dom/index.tsx Outdated
brophdawg11
brophdawg11 commented Aug 11, 2023
View reviewed changes
Comment thread packages/react-router-dom/server.tsx Outdated

@brophdawg11 brophdawg11 Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bad assumption - while they're properly encoded in request.url, we decode paths for matching and this function is used to re-encode in external-facing paths.

@brophdawg11
brophdawg11 force-pushed the brophdawg11/encode-server-HTML-paths branch from 9a58358 to f135058 Compare August 11, 2023 16:14
@ryanflorence
ryanflorence merged commit 8b3559a into dev Aug 11, 2023
@ryanflorence
ryanflorence deleted the brophdawg11/encode-server-HTML-paths branch August 11, 2023 17:38
@brophdawg11 brophdawg11 mentioned this pull request Aug 14, 2023
Closed
1 task done
This was referenced Aug 28, 2023
Closed
Closed
Merged
@github-actions

github-actions Bot commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version 6.16.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions Bot mentioned this pull request Sep 13, 2023
Merged
@github-actions

github-actions Bot commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version 6.16.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

mvattuone
mvattuone reviewed Sep 20, 2023
View reviewed changes
Comment thread packages/react-router-dom/server.tsx
let href = typeof to === "string" ? to : createPath(to);
let encoded = ABSOLUTE_URL_REGEX.test(href)
? new URL(href)
: new URL(href, "http://localhost");

@mvattuone mvattuone Sep 20, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it have been possible to make that base configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mvattuone mvattuone mvattuone left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brophdawg11 @mvattuone @ryanflorence