accept primitive.class in annotations#25363
Merged
Merged
Conversation
SolalPirelli
approved these changes
Feb 27, 2026
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Mar 20, 2026
When we parse java code, we should also handle when `int.class`, `byte.class`,... (all primitives) are present in annotations. We used to discard them before. ## How much have you relied on LLM-based tools in this contribution? None. ## Additional notes Closes scala#19643 [Cherry-picked 5dfd0cc][modified]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we parse java code, we should also handle when
int.class,byte.class,... (all primitives) are present in annotations. We used to discard them before.How much have you relied on LLM-based tools in this contribution?
None.
Additional notes
Closes #19643