Skip to content

improvement: Use method type if it's available#25641

Merged
zielinsky merged 1 commit into
scala:mainfrom
tgodzik:fix-completions-untyped
Mar 30, 2026
Merged

improvement: Use method type if it's available#25641
zielinsky merged 1 commit into
scala:mainfrom
tgodzik:fix-completions-untyped

Conversation

@tgodzik

@tgodzik tgodzik commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

Even if the apply has an error, we can provide sensible completions.

Fixes #25635

How much have you relied on LLM-based tools in this contribution?

Nothing (train mode on)

How was the solution tested?

Added tests

Additional notes

@tgodzik tgodzik requested review from rochala and zielinsky March 28, 2026 10:37
Even if the apply has an error, we can provide sensible completions.
@tgodzik tgodzik force-pushed the fix-completions-untyped branch from d54952b to c01e3a2 Compare March 28, 2026 10:40

@zielinsky zielinsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zielinsky zielinsky merged commit 724e9c3 into scala:main Mar 30, 2026
106 of 107 checks passed
@WojciechMazur WojciechMazur added this to the 3.8.4 milestone Mar 31, 2026
tgodzik added a commit to scala/scala3-lts that referenced this pull request Apr 8, 2026
Even if the apply has an error, we can provide sensible completions.

Fixes scala#25635


## How much have you relied on LLM-based tools in this contribution?

Nothing (train mode on)

## How was the solution tested?

Added tests

## Additional notes
[Cherry-picked 724e9c3]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggest completions on result of method call if the type is unambiguous, even if parameters don't typecheck

3 participants