Require explicit types in assumeSafe definitions in the empty package#25795
Merged
Conversation
noti0na1
added a commit
that referenced
this pull request
Apr 15, 2026
) See individual commit titles for details what got fixed. Three main areas of fixes: - Infrastructure dealing with objects: subsumes rule, pickling/unpickling of use sets, refinements to pathRoot and pathOwner - Fixes to recheckIdent: Corrections to what is the proper prefix to check, also include methods that are not in some enclosing scope in checks. - Fixes to explicit checks: Don't exempt definitions in the empty package if they are compiled in safe mode or wrapped in an `@assumeSafe`. Merge the diverging definitions of isExemptFromExplicitChecks in CheckCaptures and CaptureOps. EDIT: These are now in #25795. Fixes #25758
Also: Merge the duplications of two isExemptFromExplicitChecks definitions that diverged with subtle differences.
odersky
force-pushed
the
assume-safe-emptypkg
branch
from
814e2bd to
ff12817
Compare
noti0na1
approved these changes
Apr 15, 2026
WojciechMazur
added
the
backport:nominated
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: Merge the duplications of two isExemptFromExplicitChecks definitions that
diverged with subtle differences.
Based on #25770. Only last commit is new.