Skip to content

Fix false-positive pat mat unreachable case warning#25978

Merged
zielinsky merged 1 commit into
scala:mainfrom
Gedochao:fix/25928
May 12, 2026
Merged

Fix false-positive pat mat unreachable case warning#25978
zielinsky merged 1 commit into
scala:mainfrom
Gedochao:fix/25928

Conversation

@Gedochao

@Gedochao Gedochao commented May 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #25928

How much have you relied on LLM-based tools in this contribution?

Extensively. Vibe coded.

How was the solution tested?

New automated tests (including the issue's reproducer)

@Gedochao Gedochao force-pushed the fix/25928 branch 3 times, most recently from cba7d9a to 7c8dfa1 Compare May 5, 2026 13:15
@Gedochao Gedochao requested a review from zielinsky May 5, 2026 14:31
@Gedochao Gedochao marked this pull request as ready for review May 5, 2026 14:31

@zielinsky zielinsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems to be consistent with the current code; I just have one comment

Comment thread compiler/src/dotty/tools/dotc/core/TypeComparer.scala Outdated

@zielinsky zielinsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zielinsky zielinsky merged commit 42d54ff into scala:main May 12, 2026
46 checks passed
@Gedochao Gedochao deleted the fix/25928 branch May 13, 2026 08:40
@Gedochao Gedochao added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label May 13, 2026
@Gedochao Gedochao added this to the 3.8.4 milestone May 13, 2026
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels May 20, 2026
WojciechMazur added a commit that referenced this pull request May 20, 2026
….4 (#26103)

Backports #25978 to the 3.8.4-RC2.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels May 20, 2026
bishabosha pushed a commit to dotty-staging/dotty that referenced this pull request Jun 5, 2026
Fixes scala#25928

## How much have you relied on LLM-based tools in this contribution?
Extensively. Vibe coded.

## How was the solution tested?
New automated tests (including the issue's reproducer)
alexarchambault pushed a commit to plasmon-scala/scala3 that referenced this pull request Jun 16, 2026
Fixes scala#25928

## How much have you relied on LLM-based tools in this contribution?
Extensively. Vibe coded.

## How was the solution tested?
New automated tests (including the issue's reproducer)
[Cherry-picked 42d54ff]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:done This PR was successfully backported.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive warning Unreachable case

3 participants