Bump MSRV to 1.70.0#2651
Merged
Merged
Conversation
Enselic
requested changes
Aug 28, 2023
Enselic
left a comment
Enselic
left a comment
Collaborator
There was a problem hiding this comment.
I am strongly in favor of this change. But can you please undo your changes that made some multi line dependency declarations single line?
Collaborator
|
Thanks! Looks good to me. Also please add an entry about the MSRV bump in CHANGELOG.md. Once that is done I think we should merge this. A change like this tends to conflict with other changes over time. @sharkdp has previously said that it is fine to bump MSRV as soon as we have the slightest reason to bump it. |
The intention is to take advantage of `std::io::IsTerminal` that landed in 1.70.0, both in `bat` and its dependencies (`clap`, `grep-cli`). This will fix #2570 as well - `grep-cli` 0.1.9 has a patch for that. Signed-off-by: mataha <mataha@users.noreply.github.com>
Contributor
Author
Done. |
Enselic
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention is to take advantage of
std::io::IsTerminalthat landed in 1.70.0, both inbatand its dependencies (clap,grep-cli).This will fix #2570 as well -
grep-cli0.1.9 has a patch for that.