fix(deploy): use absolute path to load component source#593
Conversation
f38598d to
c273194
Compare
There was a problem hiding this comment.
Thank you @FrankYang0529 for fixing this bug. Manually tested. Also was nice to see the push method on PathBuf being used. I usually use join on Path so I got to learn something new. 🎉
We might also want to absolutize the app dir reference as a follow up.
Would you mind also signing your commit so we can merge?
|
@FrankYang0529 info on signing if you need it: https://spin.fermyon.dev/contributing/ Lmk if you need any help. |
c273194 to
fa9ff74
Compare
Do you mean also put app_folder in
I sign it. Thank you. |
itowlson
left a comment
There was a problem hiding this comment.
This looks good - thanks! Comments are mostly minor nits; the only important thing is that when we try to open a file it's really important to provide a with_context with the file name because the stdlib error gives you no clue at all which file the operation has failed on - this was the issue I hit in #590! Thanks again!
Signed-off-by: Frank Yang <yangpoan@gmail.com>
fa9ff74 to
ac8ccd5
Compare
itowlson
left a comment
There was a problem hiding this comment.
LGTM - thanks for the fixes!
fixes #590