Repository navigation
LaTeX: a "[" after a line break or at the start of a list item stays text - #1099
Merged
Merged
Conversation
Member
|
Thanks for the contribution, @webdevtodayjason! This has landed in main. If you haven't already, come join us on Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A list item whose text starts with "[" (for example "[x] Buy milk") exported as
\item [x] Buy milk. LaTeX, and WordCraft's own LaTeX import, read "[x]" as the item's label, so the bullet became "x" and the brackets were lost. Text that starts with "[" after a line break exported as\\followed by[1] b, which LaTeX reads as the line break's optional spacing argument: pdfLaTeX stops with "Illegal unit of measure" ("Missing number" for "[x]") and the bracketed text disappears.escape_textnow writes such a bracket as{[}when nothing visible comes before it on the line. Brackets after text are unchanged.leading_brackets_stay_textfails on main and passes with the fix.cargo test -p wordcraft-formats,cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo xtask assets,layersandwasmpass.cargo xtask cistops on three wordcraft-layout tests (deleted_text_adds_no_line_break_opportunity_without_markup,hidden_text_adds_no_line_break_opportunity_when_not_shown,tight_wrap_follows_an_ellipse) that fail the same way on unchanged main.The first commit adds my entry to
contributors/people.toml.