Repository navigation
Keep a paragraph's space after clear of the footnote separator (#1116) - #1140
Merged
echelon merged 3 commits intoOct 14, 2026
Merged
Conversation
…separator On a page with footnotes (already there or brought by the line), a paragraph's last line only fits if its space after fits above the notes area too; otherwise it goes to the next page with its note (and, with widow control, one more line). Contextual spacing and automatic spacing between list items drop the requirement; pages without notes are unchanged (space after may still run past the bottom margin). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dkhlapov
force-pushed
the
issue-1116-footnote-space-after
branch
from
October 12, 2026 23:50
82bc55b to
206654c
Compare
dkhlapov
marked this pull request as ready for review
October 12, 2026 23:50
…de's tests, only on pages with notes Contextual spacing drops a paragraph's space after only when that paragraph asks for it, and the next paragraph counts as a list item only when it gets a label (Numbering::shows_label), as in the spacing between paragraphs. The kept space after is worked out only for a last line on a page with notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Review follow-ups (7710fc7):
Full CI passed. |
# Conflicts: # ROADMAP.md # docs/layout-parity.md
Member
|
Thanks for the contribution, @dkhlapov! This has landed in main. If you haven't already, come join us on Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1116: keep a paragraph's space after clear of the footnote separator
Fixes #1116. On a page with footnotes, a paragraph that ends there now keeps its space after above the footnote separator. When the space after doesn't fit, the last line goes to the next page with its note (with widow control, one more line goes too), as in Word.
Tests:
space_after_stays_clear_of_the_footnote_separatorsweeps a paragraph with 6 pt space after, and a footnote on its last line, down the page 1 pt at a time. It fails on main.space_after_may_overflow_the_bottom_margin_without_noteschecks that pages without notes are unchanged.cargo xtask cipasses.🤖 Generated with Claude Code