Repository navigation
Read Aloud starts PowerShell without a console window (#1122) - #1150
Merged
Merged
Conversation
On Windows the speech program is PowerShell, a console program: each sentence it spoke flashed a console window over the document. It now starts with CREATE_NO_WINDOW. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dkhlapov
force-pushed
the
issue-1122-read-aloud-console
branch
from
October 13, 2026 00:00
1ef41d9 to
fe1c09e
Compare
dkhlapov
changed the title
dkhlapov
marked this pull request as ready for review
October 13, 2026 00:00
…asses windows_speech builds the PowerShell program, arguments and creation flags that speak() turns into its Command; std can't read creation flags back from a Command, so the test checks that value (CREATE_NO_WINDOW) and the arguments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Review follow-up (2fcf718): the test now checks the value the spawn really uses. |
Member
|
Thanks for the contribution, @dkhlapov! This has landed in main. If you haven't already, come join us on Discord: https://discord.gg/artcraft |
zhaikong
pushed a commit
to zhaikong/wordcraft
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1122: Read Aloud starts PowerShell without a console window
Fixes #1122. On Windows, Read Aloud speaks each sentence through PowerShell (System.Speech). PowerShell is a console program, so every sentence flashed a console window over the document. The speech command now starts with
CREATE_NO_WINDOW(CommandExt::creation_flags); macOS (say) and Linux (espeak-ng) are unchanged.Tests:
speech::tests::powershell_starts_without_a_console_windowpins the flag value.cargo check -p wordcraft-engine --target x86_64-pc-windows-gnupasses.Not tried on a Windows machine yet.
🤖 Generated with Claude Code