Repository navigation
Draw: Ink to Shape recognises arrows - #1520
Merged
Merged
Conversation
dkhlapov
marked this pull request as ready for review
October 14, 2026 02:52
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dkhlapov
force-pushed
the
feat-ink-to-shape-arrows
branch
from
October 14, 2026 07:12
d49d211 to
de99688
Compare
# Conflicts: # ROADMAP.md # docs/gaps.md # docs/ui-parity.md
Member
|
Thanks for the contribution, @dkhlapov! This has landed in main. If you haven't already, come join us on Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap 12 in
docs/gaps.md(Draw / ink): Ink to Shape recognises arrows.WordCraft's own design. Word for Mac 16.113.4 has no Ink to Shape at all (checked by hand), so there was nothing to observe. This extends WordCraft's own recogniser (#395) with its own geometry.
What changed
crates/engine/src/cmd/ink_shape.rs:recognisenow finds single-stroke arrows: a straight shaft, then two barbs at the tip, drawn shaft-first or head-first.None.draw.rs: an arrow becomes a straight connector with flips and an end arrowhead. That's how Insert › Shapes arrows are stored, so it saves to DOCX (a:tailEnd), draws on screen and in PDF, and can be moved like any connector.Not done:
Both are noted in gap 12.
Docs:
docs/gaps.mdgap 12;docs/hardware-parity.mdPen / stylus row, now 🟡 (ink, eraser and Ink to Shape landed; pressure and Ink to Math are missing);docs/ui-parity.mdanddocs/target-app-parity.md;ROADMAP.mdprogress-log entry;Tests (
ink_shape.rs,draw.rs)All failed before the change or the fix that needed them:
Guards: V, checkmark, L, hook (
None), Y, k, zigzag and line plus scribble all stay ink.cargo xtask ci: all 6 steps passed (fmt, clippy, test, assets, layers, wasm).Review
head_at_startis reserved for double-headed arrows.🤖 Generated with Claude Code