Repository navigation
Docs: list the CharProps and ParaProps fields (#865) - #899
Merged
Merged
Conversation
Member
|
Thanks for the contribution, @marcoarnulfo! This is now merged into main. If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
rbr48
pushed a commit
to rbr48/wordcraft
that referenced
this pull request
Oct 13, 2026
…old#899) * Docs: list the CharProps and ParaProps fields (storytold#865) * docs/mcp.md: color also takes RRGGBB and #RRGGBB (storytold#865, storytold#881) --------- Co-authored-by: Brandon Thomas <echelon@gmail.com> (cherry picked from commit b9899f4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #865: the docs half (#881 is the colour half; together they cover the issue).
docs/mcp.mdgets a "Character and paragraph properties" section listing every field ofCharPropsandParaPropsasformat.set,para.set,styles.modifyand the table style commands take them: the JSON name, its type, and the accepted values for the enums,lineSpacing,numbering,tabsand borders. It also says that an unknown field is ignored rather than refused, which is what makes a misspelt name hard to spot.docs/control-protocol.mdlinks to it. Thecolorrow describes what main accepts today ("Auto"or{"Rgb": [r, g, b]}); whichever of this and #881 lands second can add the hex form to that line.Validation:
crates/doc/src/props.rs(serde renames,autoSpaceDE/autoSpaceDN,inside_vinBorders, the taggedlineSpacing).CharPropsand aParaPropswith every documented field, plus every listed enum value, through serde; a misspelt field name made it fail.