fix: include tests in sdist - #1099
Merged
noahnu merged 1 commit intoMay 31, 2026
Merged
Conversation
Collaborator
|
I'm not too familiar with why it's valuable to add tests to the sdist. What's the use case? Do we also need to ensure folks running these tests install the relevant test dependencies? Or is that something we put in the documentation? |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 24 24
Lines 1717 1717
=======================================
Hits 1672 1672
Misses 45 45 🚀 New features to boost your workflow:
|
noahnu
approved these changes
May 31, 2026
noahnu
left a comment
Collaborator
There was a problem hiding this comment.
I did some further research on this, I think it's fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conftest.pyin the source distribution.Validation
python -m hatchling build -t sdist -d ..\tmp\syrupy-baseline-sdistbefore the change showed 0tests/entries and no rootconftest.pyin the sdist.python -m hatchling build -t sdist -d ..\tmp\syrupy-final-sdistpassed after the change.tests/entries, rootconftest.py,tests/conftest.py, and representative test files in the sdist.python -X utf8 -m pytest tests -qpassed: 376 passed, 60 xfailed, 6 xpassed.git diff --checkpassed.Notes