Repository navigation
chore(modules): re-pin tinymemory to v1.22.4 - #6924
Conversation
Update the tinymemory module dependency to version 1.22.4 across all CI workflow files, Cargo.lock files, and the registry record. This includes updating the version string, release URL, and all platform-specific archive filenames and SHA-256 checksums to match the new release. Auto-committed-on: macbook Co-authored-by: Medulla <medulla@tinyhumans.ai>
Updates the pinned artifact version from 1.22.2 to 1.22.4 and extends the comment to note that the new release makes `store` return before its vectors are embedded, with no change to the advertised capability families. Auto-committed-on: macbook Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The tinymemory module was removed from the pin exemptions list because its legacy test-file rename commits have been released, making the pin no longer necessary. Auto-committed-on: macbook Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Pending checks: Rust E2E (mock backend), Build Playwright E2E Artifact, E2E (Playwright / web lane), Desktop E2E (full suite, 3 OS) Could not review: .github/workflows/ci-full.yml, .github/workflows/e2e-playwright.yml, .github/workflows/e2e-reusable.yml, crates/openhuman-core/src/modules/memory/capabilities.rs, crates/openhuman-core/src/modules/registry/records_memory_juice.rs Before merge
How this fits togetherflowchart LR
n0["artifact_serves"]:::impacted
n1["artifact_capabilities"]:::impacted
n2["capabilities_for"]:::impacted
n3["assume_full_capabilities"]:::impacted
n0 -->|calls| n3
n1 -->|calls| n2
n1 -->|calls| n3
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughTinyMemory references now use version 1.22.4. The registry metadata, capability pin, vendor submodule, and CI workflows were updated. The TinyMemory pin exemption was removed. ChangesTinyMemory release update
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The TinyMemory release references are aligned, with no identified issue requiring resolution before merge. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The update preserves the advertised capabilities and release-selection structure. No introduced security defect was established, but the released implementation was unavailable, leaving background embedding behavior during deletion, shutdown and permission changes unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit checks the pinned release, Comment |
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: .github/workflows/ci-full.yml, .github/workflows/e2e-playwright.yml, .github/workflows/e2e-reusable.yml, crates/openhuman-core/src/modules/memory/capabilities.rs, crates/openhuman-core/src/modules/registry/records_memory_juice.rs.
$0.0040 · 34,310 in / 6,075 out · 2,048 cached (6%) · deepseek/deepseek-v4-flash
tests: $0.0009 · 8,164 in / 958 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0009 · 8,038 in / 1,054 out · 0 cached (0%) · deepseek/deepseek-v4-flash
e2e: $0.0013 · 11,439 in / 2,156 out · 1,536 cached (13%) · deepseek/deepseek-v4-flash
tinysweeper
Bot
added
the
priority: p3
|
Bench result with this pin (OpenHuman micro suite, 5 tasks x 3 rounds = 15 samples per side,
Cold start and CPU are unchanged, as expected: the change only removes the two embedding waits after the last model call. Caveat: the two sides were run at different times rather than interleaved, so I would read the wall median as indicative; the tail drop is far outside the run-to-run spread. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
Re-pins the
tinymemorymodule to v1.22.4, which carries tinymemory#189:Memory::storenow returns before its vectors are embedded.Why
A traced bench turn (OpenHuman, current main) spent about 1.5 s after the last model response in two sequential memory autosaves (
finalize_after_durable_commit). Eachstorewaited on a cloud embedding call, 655 ms and 847 ms, and both calls failed because the harness has no real TinyHumans credential. The write still succeeded without a vector, so the wait bought nothing. With a working key each autosave still costs a network round trip on the end of every turn.The module is loaded from the published release, not built from the gitlink, so the fix reaches OpenHuman only through this pin.
Changes
registry/records_memory_juice.rs: version, release URL and the 11 per-platform archives with their digests, copied from the published v1.22.4checksum.toml(not from a local build).ci-full.yml,e2e-playwright.yml,e2e-reusable.yml: thememory_version/memory_sha256fixtures (ubuntu-22.04-x86_64 row).modules/memory/capabilities.rs:ARTIFACT_CAPABILITIES_PINto 1.22.4.git diff v1.22.2..v1.22.4over the capability files is empty, so the advertised families are unchanged.Cargo.lock,crates/openhuman-app/Cargo.lock, and thevendor/tinymemorygitlink (v1.22.4,ddabd24).module-pin-exemptions.json: drops thetinymemoryexemption, since the registry pin and the submodule now agree exactly and the gate rejects a stale one.Verification
cargo test -p openhuman --lib -- modules::registrypasses, and so doesthe_capability_list_matches_the_pinned_release.node scripts/ci/check-module-pins.mjsno longer reportstinymemory. It still reports other modules in my checkout (stale exemptions for tinydocs, tinywallet and others); I did not touch those.Summary by CodeRabbit
storebefore generating embedding vectors.