Skip to content

Revert "Issue Reporters (#3707)"#3796

Merged
Brooooooklyn merged 1 commit into
mainfrom
revert-issue-reporters
Feb 14, 2023
Merged

Revert "Issue Reporters (#3707)"#3796
Brooooooklyn merged 1 commit into
mainfrom
revert-issue-reporters

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Contributor

This reverts commit dae3e21.

This commit makes the turbotrace hanging, x-ref: https://vercel.slack.com/archives/C02UJN0A1UL/p1676369060652879

@vercel

vercel Bot commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Feb 14, 2023 at 0:40AM (UTC)
9 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 0:40AM (UTC)

@Brooooooklyn Brooooooklyn merged commit 6d5fee7 into main Feb 14, 2023
@Brooooooklyn Brooooooklyn deleted the revert-issue-reporters branch February 14, 2023 12:53
@github-actions

github-actions Bot commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for 8cd83d6

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.22ms ± 0.09ms 10.10ms ± 0.06ms -1.23%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.03ms ± 0.17ms 12.13ms ± 0.25ms +0.88%
bench_hmr_to_commit/Turbopack RSC/1000 modules 531.07ms ± 1.83ms 531.02ms ± 2.93ms -0.01%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.36ms ± 0.09ms 10.36ms ± 0.07ms +0.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 9212.35µs ± 73.65µs 9161.02µs ± 80.88µs -0.56%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.98ms ± 0.12ms 11.35ms ± 0.12ms +3.38%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9248.47µs ± 116.61µs 9222.98µs ± 112.38µs -0.28%
bench_hydration/Turbopack RCC/1000 modules 4378.97ms ± 14.31ms 4370.51ms ± 14.66ms -0.19%
bench_hydration/Turbopack RSC/1000 modules 3964.58ms ± 18.96ms 3952.12ms ± 10.63ms -0.31%
bench_hydration/Turbopack SSR/1000 modules 3845.18ms ± 18.40ms 3837.72ms ± 21.54ms -0.19%
bench_startup/Turbopack CSR/1000 modules 2892.65ms ± 13.52ms 2862.14ms ± 19.85ms -1.05%
bench_startup/Turbopack RCC/1000 modules 2658.12ms ± 8.31ms 2650.91ms ± 9.36ms -0.27%
bench_startup/Turbopack RSC/1000 modules 2580.76ms ± 10.66ms 2552.77ms ± 12.29ms -1.08%
bench_startup/Turbopack SSR/1000 modules 2205.64ms ± 3.70ms 2200.47ms ± 3.80ms -0.23%

timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 14, 2023
The `experimental.turbotrace.memoryLimit` is not actually working, we
need to use `turbo_malloc` as the global allocator to make it work.

~~Block by:~~
- swc-project/swc#6940
- vercel/turborepo#3772

## This PR also upgrades `turbopack-230213.2` to `turbopack-230214.1`

- vercel/turborepo#3767
- vercel/turborepo#3772
- vercel/turborepo#3762
- vercel/turborepo#3741
- vercel/turborepo#3796
wbinnssmith added a commit that referenced this pull request Feb 14, 2023
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
This reverts commit a8612abf5edbde3013d6fcf8845976f422cb2ffc.

This commit makes the `turbotrace` hanging, x-ref:
https://vercel.slack.com/archives/C02UJN0A1UL/p1676369060652879
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
This reverts commit a8612abf5edbde3013d6fcf8845976f422cb2ffc.

This commit makes the `turbotrace` hanging, x-ref:
https://vercel.slack.com/archives/C02UJN0A1UL/p1676369060652879
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants