Skip to content

fix(runtime): DevTools recommendation shows for all browsers - #8638

Merged
yyx990803 merged 1 commit into
vuejs:2.6from
AlexMaguey:fix/devtools-recommendation
Dec 20, 2018
Merged

fix(runtime): DevTools recommendation shows for all browsers#8638
yyx990803 merged 1 commit into
vuejs:2.6from
AlexMaguey:fix/devtools-recommendation

Conversation

@AlexMaguey

Copy link
Copy Markdown

Closes #8634

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva

posva commented Aug 11, 2018

Copy link
Copy Markdown
Member

Thanks for the PR but let's wait for the confirmation first 🙂

@TheAlexLichter

Copy link
Copy Markdown
Contributor

ping

@Justineo

Justineo commented Dec 6, 2018

Copy link
Copy Markdown
Member

It seems to be the only place where isChrome is used. We can delete its definition as well.

@yyx990803
yyx990803 changed the base branch from dev to 2.6 December 20, 2018 22:04
@yyx990803
yyx990803 merged commit 22ad266 into vuejs:2.6 Dec 20, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants