fix(#9198): fix merged twice bug when passing extended constructor to mixins - #9199
Merged
Conversation
posva
reviewed
Dec 13, 2018
|
|
||
| const vm = new Child() | ||
|
|
||
| expect(typeof vm.$options.methods.a).toBe('function') |
Contributor
Author
There was a problem hiding this comment.
This test is to make sure the fix does not break normal inheritance from grandparent, in this test, mixin1 and Child
yyx990803
pushed a commit
that referenced
this pull request
Jan 11, 2019
yyx990803
added a commit
that referenced
this pull request
Jan 11, 2019
The fix landed in #9199 causes further extended constructors used as mixins to drop options from its inheritance chain, so a different fix is needed.
yyx990803
added a commit
that referenced
this pull request
Jan 11, 2019
The fix landed in #9199 causes further extended constructors used as mixins to drop options from its inheritance chain, so a different fix is needed.
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
The fix landed in vuejs#9199 causes further extended constructors used as mixins to drop options from its inheritance chain, so a different fix is needed.
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
The fix landed in vuejs#9199 causes further extended constructors used as mixins to drop options from its inheritance chain, so a different fix is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(#9198)
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: