include omit entries in hash#3552
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
jridgewell
approved these changes
Jan 31, 2023
| need_hash = true; | ||
| } | ||
| // Marker to end evaluate | ||
| hasher.write_value(true); |
Contributor
There was a problem hiding this comment.
Should this have written a length header instead of a bool footer?
Contributor
There was a problem hiding this comment.
Both evaluate and omit could write length headers (or 0 when N/A).
Contributor
Benchmark for 29569da
Click to view full benchmark
|
Contributor
|
Contributor
Benchmark for 4f716e0
Click to view full benchmark
|
Contributor
Benchmark for f00ca10
Click to view full benchmark
|
mehulkar
pushed a commit
that referenced
this pull request
Feb 1, 2023
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 10, 2023
…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turborepo#3540 - vercel/turborepo#3549 - vercel/turborepo#3465 - vercel/turborepo#3550 - vercel/turborepo#3495 - vercel/turborepo#3624 - vercel/turborepo#3600 - vercel/turborepo#3676 - vercel/turborepo#3689 # Fixes - vercel/turborepo#3437 - vercel/turborepo#3542 - vercel/turborepo#3531 - vercel/turborepo#3552 - vercel/turborepo#3551 - vercel/turborepo#3597 - vercel/turborepo#3644 - vercel/turborepo#3623 - vercel/turborepo#3634 - vercel/turborepo#3574 - vercel/turborepo#3673 - vercel/turborepo#3675 - vercel/turborepo#3723 - vercel/turborepo#3677 - vercel/turborepo#3717 - vercel/turborepo#3701 # Performance Improvements - vercel/turborepo#3361 - vercel/turborepo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ