Skip to content

use apply when expanding amd pattern matches#3677

Merged
ForsakenHarmony merged 3 commits into
mainfrom
hrmny/web-438-use-apply-when-expanding-amd-pattern-match
Feb 9, 2023
Merged

use apply when expanding amd pattern matches#3677
ForsakenHarmony merged 3 commits into
mainfrom
hrmny/web-438-use-apply-when-expanding-amd-pattern-match

Conversation

@ForsakenHarmony

@ForsakenHarmony ForsakenHarmony commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Feb 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-benchmark ❌ Failed (Inspect) Feb 9, 2023 at 5:58PM (UTC)
turbo-buildcontainer ❌ Failed (Inspect) Feb 9, 2023 at 5:58PM (UTC)
turbo-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 5:58PM (UTC)
turbo-docs-at18 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 5:58PM (UTC)
turbo-js-q5o2 ❌ Failed (Inspect) Feb 9, 2023 at 5:58PM (UTC)
turbo-turbo-tracing-next-plugin-ek5c ❌ Failed (Inspect) Feb 9, 2023 at 5:58PM (UTC)
turbo-with-mongodb-mongoose ❌ Failed (Inspect) Feb 9, 2023 at 5:58PM (UTC)
10 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 9, 2023 at 5:58PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2023 at 5:58PM (UTC)

@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review February 7, 2023 18:19
@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner February 7, 2023 18:19
@github-actions

github-actions Bot commented Feb 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions

github-actions Bot commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Benchmark for 5dac4ff

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9197.49µs ± 58.90µs 9162.94µs ± 75.51µs -0.38%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9322.73µs ± 42.82µs 9373.99µs ± 95.35µs +0.55%
bench_hmr_to_commit/Turbopack RSC/1000 modules 490.33ms ± 2.48ms 496.44ms ± 2.15ms +1.25%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9317.22µs ± 93.31µs 9344.60µs ± 85.48µs +0.29%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8166.80µs ± 87.44µs 8184.63µs ± 75.39µs +0.22%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8408.58µs ± 116.79µs 8344.22µs ± 70.68µs -0.77%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8269.10µs ± 75.15µs 8296.41µs ± 80.90µs +0.33%
bench_hydration/Turbopack RCC/1000 modules 4217.36ms ± 7.78ms 4222.69ms ± 13.34ms +0.13%
bench_hydration/Turbopack RSC/1000 modules 3816.30ms ± 14.58ms 3805.93ms ± 11.60ms -0.27%
bench_hydration/Turbopack SSR/1000 modules 3680.85ms ± 21.62ms 3679.73ms ± 16.62ms -0.03%
bench_startup/Turbopack CSR/1000 modules 2786.77ms ± 10.54ms 2753.73ms ± 7.65ms -1.19%
bench_startup/Turbopack RCC/1000 modules 2564.00ms ± 5.23ms 2563.85ms ± 9.57ms -0.01%
bench_startup/Turbopack RSC/1000 modules 2451.30ms ± 10.88ms 2437.54ms ± 8.28ms -0.56%
bench_startup/Turbopack SSR/1000 modules 2107.84ms ± 4.78ms 2115.53ms ± 4.05ms +0.36%

sokra
sokra previously requested changes Feb 7, 2023
View reviewed changes
Comment thread crates/turbopack-ecmascript/src/references/amd.rs Outdated
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-438-use-apply-when-expanding-amd-pattern-match branch from 9be0cdd to 21b7d42 Compare February 8, 2023 20:23
@ForsakenHarmony

ForsakenHarmony commented Feb 8, 2023

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony requested a review from sokra February 8, 2023 20:26
@github-actions

github-actions Bot commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Benchmark for 720cac2

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8983.52µs ± 132.26µs 8966.02µs ± 104.20µs -0.19%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9113.92µs ± 104.75µs 9237.00µs ± 102.62µs +1.35%
bench_hmr_to_commit/Turbopack RSC/1000 modules 479.28ms ± 2.69ms 485.04ms ± 2.08ms +1.20%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9162.61µs ± 71.25µs 9104.80µs ± 113.42µs -0.63%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8001.98µs ± 84.58µs 8130.10µs ± 64.77µs +1.60%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8319.28µs ± 75.46µs 8233.28µs ± 95.86µs -1.03%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8065.83µs ± 98.14µs 8098.24µs ± 60.61µs +0.40%
bench_hydration/Turbopack RCC/1000 modules 4131.70ms ± 12.62ms 4162.28ms ± 11.71ms +0.74%
bench_hydration/Turbopack RSC/1000 modules 3711.29ms ± 18.04ms 3727.19ms ± 14.05ms +0.43%
bench_hydration/Turbopack SSR/1000 modules 3623.28ms ± 18.26ms 3643.60ms ± 11.38ms +0.56%
bench_startup/Turbopack CSR/1000 modules 2760.19ms ± 9.73ms 2732.50ms ± 7.79ms -1.00%
bench_startup/Turbopack RCC/1000 modules 2509.30ms ± 5.56ms 2499.94ms ± 3.49ms -0.37%
bench_startup/Turbopack RSC/1000 modules 2396.07ms ± 7.81ms 2392.21ms ± 11.32ms -0.16%
bench_startup/Turbopack SSR/1000 modules 2072.23ms ± 2.86ms 2077.94ms ± 4.10ms +0.28%

@ForsakenHarmony ForsakenHarmony dismissed sokra’s stale review February 9, 2023 16:51

addressed comments

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-438-use-apply-when-expanding-amd-pattern-match branch from 21b7d42 to 77a3323 Compare February 9, 2023 17:00
@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) February 9, 2023 17:00
@ForsakenHarmony ForsakenHarmony merged commit 3363573 into main Feb 9, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/web-438-use-apply-when-expanding-amd-pattern-match branch February 9, 2023 18:21
@github-actions

github-actions Bot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Benchmark for 48dc5f5

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9245.38µs ± 82.75µs 9413.44µs ± 96.83µs +1.82%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9560.78µs ± 63.74µs 9519.49µs ± 79.72µs -0.43%
bench_hmr_to_commit/Turbopack RSC/1000 modules 486.74ms ± 1.21ms 489.46ms ± 2.71ms +0.56%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9452.16µs ± 84.31µs 9457.60µs ± 85.94µs +0.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8316.66µs ± 56.10µs 8389.10µs ± 42.51µs +0.87%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8559.02µs ± 53.52µs 8462.65µs ± 50.38µs -1.13%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8484.69µs ± 65.56µs 8460.38µs ± 62.52µs -0.29%
bench_hydration/Turbopack RCC/1000 modules 4176.81ms ± 8.70ms 4155.44ms ± 6.97ms -0.51%
bench_hydration/Turbopack RSC/1000 modules 3756.59ms ± 18.35ms 3822.54ms ± 24.79ms +1.76%
bench_hydration/Turbopack SSR/1000 modules 3679.89ms ± 10.40ms 3638.92ms ± 22.25ms -1.11%
bench_startup/Turbopack CSR/1000 modules 2769.51ms ± 12.86ms 2770.87ms ± 9.56ms +0.05%
bench_startup/Turbopack RCC/1000 modules 2545.00ms ± 5.89ms 2531.40ms ± 8.60ms -0.53%
bench_startup/Turbopack RSC/1000 modules 2420.21ms ± 7.75ms 2433.59ms ± 4.22ms +0.55%
bench_startup/Turbopack SSR/1000 modules 2102.21ms ± 2.38ms 2102.30ms ± 3.32ms +0.00%

@jridgewell jridgewell mentioned this pull request Feb 10, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 10, 2023
@Brooooooklyn @kodiakhq
Update turbopack to 230209.02 (#45776)Co-authored-by: kodiakhq[bot] <…
946ccb0 
…49736102+kodiakhq[bot]@users.noreply.github.com>

# New Features
- vercel/turborepo#3540
- vercel/turborepo#3549
- vercel/turborepo#3465
- vercel/turborepo#3550
- vercel/turborepo#3495
- vercel/turborepo#3624
- vercel/turborepo#3600
- vercel/turborepo#3676
- vercel/turborepo#3689

# Fixes

- vercel/turborepo#3437
- vercel/turborepo#3542
- vercel/turborepo#3531
- vercel/turborepo#3552
- vercel/turborepo#3551
- vercel/turborepo#3597
- vercel/turborepo#3644
- vercel/turborepo#3623
- vercel/turborepo#3634
- vercel/turborepo#3574
- vercel/turborepo#3673
- vercel/turborepo#3675
- vercel/turborepo#3723
- vercel/turborepo#3677
- vercel/turborepo#3717
- vercel/turborepo#3701

# Performance Improvements

- vercel/turborepo#3361 
- vercel/turborepo#3619

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
use apply when expanding amd pattern matches (vercel/turborepo#3677)
c846e0e
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
use apply when expanding amd pattern matches (vercel/turborepo#3677)
2c54812
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
use apply when expanding amd pattern matches (vercel/turborepo#3677)
9b5d892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sokra sokra Awaiting requested review from sokra

1 more reviewer

@alexkirsz alexkirsz alexkirsz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ForsakenHarmony @sokra @alexkirsz